schannel: not supported with UWP, drop redundant code#18116
schannel: not supported with UWP, drop redundant code#18116vszakats wants to merge 13 commits intocurl:masterfrom
Conversation
I'm surprised by this. Indeed the doc for InitializeSecurityContext (Schannel) function says in requirements "desktop apps only". |
Same! Setting aside the false track with mingw-w64, I'm surprised It'd be nice to actually run the built UWP binaries in CI, to catch similar |
…, update logic and message
Schannel is not supported by UWP. SSPI is also required by Schannel in
curl, and SSPI also isn't supported by UWP.
mingw-w64 is able to create such build regardless (my guess: due to API
parts not accurately marked as UWP-only), but the binary is unlikely
to work. With MSVC the failure happens at build-time.
Ref: https://learn.microsoft.com/windows/win32/api/sspi/nf-sspi-initsecurityinterfacea#requirements
Ref: https://learn.microsoft.com/windows/win32/secauthn/initializesecuritycontext--schannel#requirements
Drop all UWP-related logic, including two related feature checks, that
can now be permanently enabled.
Also:
DISABLE_SCHANNEL_CLIENT_CERT. Added withoutmention in an unrelated commit. The PR text says to save size. On x64
this is 0.3%, or 4KB out of 1.3MB. The tiny gain doesn't justify
an extra build variant. Ref: 8beff43
MPROTO_SCHANNEL_CERT_SHARE_KEYcloser to its use.#if 0.Reviewed-by: Jay Satiro
Follow-up to cd0ec47 #17089
w/o ws https://github.com/curl/curl/pull/18116/files?w=1
Tested OK also with VS2008 and WinCE: