CURLOPT: bump CURL_SSLVERSION_* macros to long#18135
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
CURLOPT: bump CURL_SSLVERSION_* macros to long#18135vszakats wants to merge 1 commit intocurl:masterfrom
CURL_SSLVERSION_* macros to long#18135vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
This patch bumps the size of these macros from `int` to `long`, while keeping their actual values the same. It may cause incompatibilities in user code, requiring the bump of holder variables and/or adding casts: - CURL_SSLVERSION_DEFAULT - CURL_SSLVERSION_SSLv2 - CURL_SSLVERSION_SSLv3 - CURL_SSLVERSION_TLSv1 - CURL_SSLVERSION_TLSv1_0 - CURL_SSLVERSION_TLSv1_1 - CURL_SSLVERSION_TLSv1_2 - CURL_SSLVERSION_TLSv1_3 - CURL_SSLVERSION_MAX_DEFAULT - CURL_SSLVERSION_MAX_NONE - CURL_SSLVERSION_MAX_TLSv1_0 - CURL_SSLVERSION_MAX_TLSv1_1 - CURL_SSLVERSION_MAX_TLSv1_2 - CURL_SSLVERSION_MAX_TLSv1_3 Also: - keep existing cast within the documentation to make sure it applies to older curl versions as well.
vszakats
changed the title
longCURL_SSLVERSION_* macros to long
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch bumps the size of these macros from
inttolong, whilekeeping their actual values the same. It may cause incompatibilities in
user code, requiring the bump of holder variables and/or adding casts:
Also:
to older curl versions as well.