New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile.m32: add support for libidn2 #1815

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@vszakats
Contributor

vszakats commented Aug 21, 2017

Caveat: libidn2 depends on a bunch of further libs. These
need to be manually specified via CURL_LDFLAG_EXTRAS.

makefile.m32: add support for libidn2
Caveat: `libidn2` depends on a bunch of further libs. These
need to be manually specified via `CURL_LDFLAG_EXTRAS`.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 22, 2017

Coverage Status

Coverage increased (+0.008%) to 73.241% when pulling 6c3ac96 on vszakats:idn2 into b939542 on curl:master.

coveralls commented Aug 22, 2017

Coverage Status

Coverage increased (+0.008%) to 73.241% when pulling 6c3ac96 on vszakats:idn2 into b939542 on curl:master.

@bagder

bagder approved these changes Aug 22, 2017

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Aug 22, 2017

Member

This is fine since libidn was replaced with libidn2 last year in configure. You have the ability to commit this yourself after rebase. Please remember to rebase on master and reference this PR with a Closes line or Ref: etc. Look in the repo for recent examples for example ebf4631 just now

Member

jay commented Aug 22, 2017

This is fine since libidn was replaced with libidn2 last year in configure. You have the ability to commit this yourself after rebase. Please remember to rebase on master and reference this PR with a Closes line or Ref: etc. Look in the repo for recent examples for example ebf4631 just now

@vszakats vszakats closed this in 43fb867 Aug 22, 2017

@vszakats vszakats deleted the vszakats:idn2 branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment