Skip to content

secs2ms(): Changes to digs[5] and digs sizeof sizeof#18167

Closed
Sackzement wants to merge 2 commits into
curl:masterfrom
Sackzement:secs2ms-fixes
Closed

secs2ms(): Changes to digs[5] and digs sizeof sizeof#18167
Sackzement wants to merge 2 commits into
curl:masterfrom
Sackzement:secs2ms-fixes

Conversation

@Sackzement

Copy link
Copy Markdown
Contributor

First commit changes this:

long val;
secs2ms(&val, "1.23456");   // val = 1234 // ok
secs2ms(&val, "1.234567");  // val = 1023 // should be 1234
secs2ms(&val, "1.2345678"); // val = 1234 // ok

Second commit would only be an issue if at some point sizeof(size_t) becomes larger than sizeof(digs) / sizeof(digs[0]).

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@bagder bagder closed this in c85c2b7 Aug 4, 2025
@bagder

bagder commented Aug 4, 2025

Copy link
Copy Markdown
Member

Thanks!

@Sackzement
Sackzement deleted the secs2ms-fixes branch August 4, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants