processhelp.pm: use Win32::Process* perl modules if available#18308
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
processhelp.pm: use Win32::Process* perl modules if available#18308vszakats wants to merge 1 commit intocurl:masterfrom
Win32::Process* perl modules if available#18308vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
`Win32::Process::List` and `Win32::Process`. To replace external calls to `tasklist.exe` and `taskkill.exe`. The perl modules are more efficient by not launching a command shell (including MSYS2) and an external process, then parse their output. According to local tests and the CI, one test session calls `tasklist.exe` 350-400 times. `taskkill.exe` is rarely called and often not called at all: https://github.com/curl/curl/actions/runs/17012376726?pr=18296 Cherry-picked from curl#18296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Win32::Process::ListandWin32::Process.To replace external calls to
tasklist.exeandtaskkill.exe.The perl modules are wrappers/binding to Win32 API calls. They avoid
launching external processes with a command shell (including MSYS2),
the external tool, and creating command-lines and parsing tool output.
According to local tests and the CI, one test session calls
tasklist.exe350-400 times.taskkill.exeis rarely called:https://github.com/curl/curl/actions/runs/17012376726?pr=18296
It's hard to predict any possible side-effect of dynamically loading
the two necessary, module DLLs into the Perl process. The MSYS2 runtime
if prone to fail when doing this in fork operations, as seen earlier
with the Win32.DLL module. But, is looks like a symptom, not the root
cause for these failures, because the failures are present with or
without perl.exe loading the Win32.DLL.
Ref: be01b60 #18287
Cherry-picked from #18296