socks_sspi: simplify, clean up Curl_SOCKS5_gssapi_negotiate#18315
Closed
socks_sspi: simplify, clean up Curl_SOCKS5_gssapi_negotiate#18315
Conversation
bagder
added a commit
that referenced
this pull request
Aug 22, 2025
This function returned error on MANY places, each with its own cleanup sequence and by the look of it almost all of them were incomplete, making them leak resources on errors. This take now gotos to the error label where it cleans everything up before returning error. This also simplifies the function a lot. Closes #18315
bagder
force-pushed
the
bagder/socks-sspi
branch
from
9384af9 to
38e129d
Compare
This function returned error on MANY places, each with its own cleanup sequence and by the look of it almost all of them were incomplete, making them leak resources on errors. This take now gotos to the error label where it cleans everything up before returning error. This also simplifies the function a lot. Closes #18315
bagder
force-pushed
the
bagder/socks-sspi
branch
from
38e129d to
401e496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function returned error on MANY places, each with its own cleanup sequence and by the look of it almost all of them were incomplete, making them leak resources on errors.
This take now gotos to the error label where it cleans everything up before returning error. This also simplifies the function a lot.
I don't build on Windows and this code is Windows specific, so I cannot verify. I'm not sure much of this is run in tests, so it is fragile to change.