Closed
Conversation
- During handshake, do not require reading more data if unprocessed encrypted data that may be a complete TLS record is already available. - During handshake, check that the socket is writeable before processing encrypted data that may require an immediate reply to the server. These two fixes are for issues that were found during renegotiation testing but could affect any handshake. Prior to this change it was possible in some abnormal network conditions for the Schannel TLS handshake procedure to erroneously wait or error. Ref: curl#18125 Closes #xxxxx
jay
added a commit
to jay/curl
that referenced
this pull request
Aug 27, 2025
Follow-up to b6a5f67 which improved the handshake procedure. Ref: curl#18323 Closes #xxxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During handshake, do not require reading more data if unprocessed encrypted data that may be a complete TLS record is already available.
During handshake, check that the socket is writeable before processing encrypted data that may require an immediate reply to the server.
These two fixes are for issues that were found during renegotiation testing but could affect any handshake.
Prior to this change it was possible in some abnormal network conditions for the Schannel TLS handshake procedure to erroneously wait or error.
Ref: #18125
Closes #xxxxx