Skip to content

spelling: file system#18348

Closed
vszakats wants to merge 1 commit intocurl:masterfrom
vszakats:filesystem
Closed

spelling: file system#18348
vszakats wants to merge 1 commit intocurl:masterfrom
vszakats:filesystem

Conversation

@vszakats
Copy link
Copy Markdown
Member

@vszakats vszakats commented Aug 22, 2025

No description provided.

@github-actions github-actions bot added cmdline tool tests CI Continuous Integration labels Aug 22, 2025
@vszakats
Copy link
Copy Markdown
Member Author

vszakats commented Aug 22, 2025

FTR hung macOS job: https://github.com/curl/curl/actions/runs/17151146207/job/48657533414?pr=18348

@icing
Copy link
Copy Markdown
Contributor

icing commented Aug 22, 2025

FTR hung macOS job: https://github.com/curl/curl/actions/runs/17151146207/job/48657533414?pr=18348

And I thought I could have a nice, relaxed weekend...

@testclutch
Copy link
Copy Markdown

testclutch commented Aug 22, 2025

Analysis of PR #18348 at 6dd31805:

Test 1557 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Generated by Testclutch

@vszakats
Copy link
Copy Markdown
Member Author

vszakats commented Aug 22, 2025

FTR hung macOS job: https://github.com/curl/curl/actions/runs/17151146207/job/48657533414?pr=18348

And I thought I could have a nice, relaxed weekend...

Yeah :( This is really odd. Last time gcc-12 came up as an outlier was its sensitivity for not pushing long types to curl_easy_setopt(). This made some tests mysteriously fail, but only with this compiler / platform. Not saying
this is related, but there is certainly something different with it. (The long type issue was a legit one; what surprised
me is that it didn't cause issues elsewhere.)

@vszakats vszakats mentioned this pull request Aug 22, 2025
Closed
vszakats added a commit that referenced this pull request Aug 22, 2025
@vszakats
test1557: pass long type to multi_setopt()
f6c2907 
A wrong type here has seen to manifest in CI failures with gcc-12 macOS.

Ref: #18348 (comment)
Ref: https://github.com/curl/curl/actions/runs/17153761944/job/48665734013?pr=18349

Follow-up to b63cce7 #18339
Follow-up to 88fc6c4 #18263

Closes #18355
@vszakats vszakats closed this in 3298a43 Aug 22, 2025
@vszakats vszakats deleted the filesystem branch August 22, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI Continuous Integration cmdline tool documentation tests tidy-up

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vszakats @icing @testclutch