openssl: remove legacy cruft, document macro guards#18351
Closed
vszakats wants to merge 24 commits intocurl:masterfrom
Closed
openssl: remove legacy cruft, document macro guards#18351vszakats wants to merge 24 commits intocurl:masterfrom
vszakats wants to merge 24 commits intocurl:masterfrom
Conversation
vszakats
changed the title
vszakats
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assume:
BIO_CTRL_EOFSSL_CTRL_SET_MSG_CALLBACKSSL_CTRL_SET_MSG_CALLBACKSSL_CTRL_SET_TLSEXT_HOSTNAMESSL_MODE_ACCEPT_MOVING_WRITE_BUFFERSSL_OP_DONT_INSERT_EMPTY_FRAGMENTSSSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUGSSL_OP_NO_COMPRESSIONSSL_OP_NO_TICKETX509_V_FLAG_PARTIAL_CHAINX509_V_FLAG_TRUSTED_FIRSTThey are present in all supported OpenSSL (and fork) versions.
replace
SSL_ERROR_WANT_EARLYwithSSL_ERROR_WANT_CLIENT_HELLO_CB.The former appeared in OpenSSL 1.1.1-dev, but renamed before
the stable release.
document support for macros:
ENGINE_CTRL_GET_CMD_FROM_NAMESSL_ERROR_WANT_ASYNC_JOBSSL_ERROR_WANT_ASYNCSSL2_VERSION_MAJORTLS1_3_VERSIONdrop legacy fallback for
CONF_MFLAGS_DEFAULT_SECTION.It was there for OpenSSL 0.9.8 support.
fix
SSL_CTRL_SET_MSG_CALLBACKaccidentally serving as a guard forOpenSSL (and forks) as a whole.
Tested OK with OpenSSL 1.0.2 and 1.1.0 in CI.
TODO:
CURL_BORINGSSL_LIKE→ openssl: add and useHAVE_BORINGSSL_LIKEinternal macro #18358CURL_OPENSSL3→ openssl: add and useHAVE_OPENSSL3internal macro #18360TLS1_3_VERSIONguards in openssl: bump minimum OpenSSL version to 3.0.0 #18330