projects: fix Windows project 'clean' function#18412
Conversation
- Fix generate.bat "-clean" option. - Minor change to version template substitutes to match old files, eg go back to using format version "11.00" instead of "11.0". - Do not remove the VC directories during clean, instead remove just the generated project files. Removing the VC directories has the unwanted behavior of removing files other than those generated. Visual Studio will generate its own preference files (like if you have some debug arguments in your .suo) and those files sit in the VC directories. We ignore these files and they are the user's files and should not be deleted. Also the user (such as me) may have their own untracked files that we shouldn't be deleting. Follow-up to 57d349f which consolidated the project templates. Closes #xxxx
59fe6b3 to
8437c7a
Compare
|
I think it may be possible to not have VCxx in the tree without affecting the untracked files so I'm going to limit this PR to getting rid of the remove directory command but not the create directory command. |
|
Peeking into the Their content, after deleting non-existing extensions: <ItemGroup>
<Filter Include="Source Files">
<UniqueIdentifier>{4FC737F1-C7A5-4376-A066-2A32D752A2FF}</UniqueIdentifier>
<Extensions>c</Extensions>
</Filter>
<Filter Include="Header Files">
<UniqueIdentifier>{93995380-89BD-4b04-88EB-625FBE52EBFB}</UniqueIdentifier>
<Extensions>h</Extensions>
</Filter>
<Filter Include="Resource Files">
<UniqueIdentifier>{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}</UniqueIdentifier>
<Extensions>rc</Extensions>
</Filter>
</ItemGroup>
</Project> |
.. also add a readme explaining that files in templ directory should not be opened with visual studio. template files are already in a tmpl directory which is enough to identify them as template files without having the templ extension. however it's possible the user won't understand that? so i added a readme explaining that they are template files.
I think they could be structural, I don't know. It's really hard to tell with MS and I'd rather not break anything. It's safer to keep them. I did add your suggested change though to limit the scope of the filtering to extensions that we actually use. edit: I realized this is what they are doing, and I do find it useful: 
|
2 participants
Fix generate.bat "-clean" option.
Minor change to version template substitutes to match old files,
eg go back to using format version "11.00" instead of "11.0".
Do not remove the VC directories during clean, instead remove just the
generated project files.
Removing the VC directories has the unwanted behavior of removing files
other than those generated. Visual Studio will generate its own
preference files (like if you have some debug arguments in your .suo)
and those files sit in the VC directories. We ignore these files and
they are the user's files and should not be deleted. Also the user (such
as me) may have their own untracked files that we shouldn't be deleting.
Follow-up to 57d349f which consolidated the project templates.
Closes #xxxx