Skip to content

ossfuzz: moving towards the ideal integration#1842

Closed
cmeister2 wants to merge 2 commits into
curl:masterfrom
cmeister2:cmeister2/ossfuzz/fuzzer
Closed

ossfuzz: moving towards the ideal integration#1842
cmeister2 wants to merge 2 commits into
curl:masterfrom
cmeister2:cmeister2/ossfuzz/fuzzer

Conversation

@cmeister2
Copy link
Copy Markdown
Contributor

  • Start with the basic code from the ossfuzz project.
  • Rewrite fuzz corpora to be binary files full of Type-Length-Value
    data, and write a glue layer in the fuzzing function to convert
    corpora into CURL options.
  • Have supporting functions to generate corpora from existing tests

This still needs integrating into the rest of the build chain properly,
but is built in CI.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 73.13% when pulling 77eb3109bc9d2f9182647480b0e0350105e8ceac on cmeister2:cmeister2/ossfuzz/fuzzer into 73fa6aa on curl:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.008%) to 73.122% when pulling 73d7d302eb4982c88a7340c1ee2f707540ada791 on cmeister2:cmeister2/ossfuzz/fuzzer into 73fa6aa on curl:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 73.111% when pulling 73d7d302eb4982c88a7340c1ee2f707540ada791 on cmeister2:cmeister2/ossfuzz/fuzzer into 73fa6aa on curl:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 73.112% when pulling 73d7d302eb4982c88a7340c1ee2f707540ada791 on cmeister2:cmeister2/ossfuzz/fuzzer into 73fa6aa on curl:master.

@cmeister2
Copy link
Copy Markdown
Contributor Author

Ok, the few tweaks I made means that this compiles within the Automake system and links to the libraries as expected (mostly this was reinstating the old code and adding some new tweaks to link to $LIB_FUZZING_ENGINE).

Comment thread tests/fuzz/Makefile.fuzz Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From IRC: this file doesn't need to exist anymore now that the Makefile.am works

Comment thread tests/fuzz/README Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need the -f Makefile.fuzz qualifier here now that Automake works

- Start with the basic code from the ossfuzz project.
- Rewrite fuzz corpora to be binary files full of Type-Length-Value
  data, and write a glue layer in the fuzzing function to convert
  corpora into CURL options.
- Have supporting functions to generate corpora from existing tests
- Integrate with Makefile.am
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 73.103% when pulling 7d63d1ebea07eed52ab64f027b73dac6a24de5e5 on cmeister2:cmeister2/ossfuzz/fuzzer into 222e65f on curl:master.

Create simple seed corpora for:
- FTP
- telnet
- dict
- tftp
- imap
- pop3

based off the tests of the same number.
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 73.122% when pulling f7f8c77 on cmeister2:cmeister2/ossfuzz/fuzzer into 222e65f on curl:master.

@cmeister2
Copy link
Copy Markdown
Contributor Author

cmeister2 commented Sep 1, 2017

As discussed on IRC, it looks like failures are due to travis issues.

@bagder bagder closed this in 1cf323e Sep 1, 2017
@lock lock Bot locked as resolved and limited conversation to collaborators May 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants