tool_getparam: warn on all unicode 0xe2 0x80 + x80-0xff prefixes - #18459
Closed
bagder wants to merge 3 commits into
Closed
tool_getparam: warn on all unicode 0xe2 0x80 + x80-0xff prefixes#18459bagder wants to merge 3 commits into
bagder wants to merge 3 commits into
Conversation
If a string argument is expected and the first two bytes are 0xe2 ex80 that's enough for curl to warn. Previously we tried to detect and warn only for the unicode double quote, but users might use single quotes, other quotes or even lead the argument with one of the "zero widths" characters. This is an attempt to detect many of those. Without triggering for "normal" IDN hostnames.
bagder
changed the title
bagder
marked this pull request as ready for review
September 3, 2025 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a string argument is expected and the first two bytes are 0xe2 ex80 and the third has the 7th bit set, that's enough for curl to warn.
Previously we tried to detect and warn only for the unicode double quote, but users might use single quotes, other quotes or even lead the argument with one of the "zero widths" characters. This is an attempt to detect many of those. Without triggering for "normal" IDN hostnames.