tidy-up: avoid using the reserved macro namespace#18482
Closed
vszakats wants to merge 9 commits intocurl:masterfrom
Closed
tidy-up: avoid using the reserved macro namespace#18482vszakats wants to merge 9 commits intocurl:masterfrom
vszakats wants to merge 9 commits intocurl:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
To avoid using the reserved macro namespace and to avoid colliding with _tcsdup as defined by Windows headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid hitting
-Wreserved-macro-identifierwhere possible.__request().__has_builtin().Follow-up to 33fd57b easy_lock: fix the #ifdef conditional for ia32_pause #9062
_random()._tcsdup()toCurl_tcsdup().To avoid using the reserved macro namespace and to avoid
colliding with
_tcsdup()as defined by Windows headers._tcsdup()in favor ofCurl_tcsdup()._use_lfn()(MS-DOS).__NO_NET_APIhack to AmigaOS.Syncing this pattern with
lib/netrc.c.Follow-up to 784a8ec tidy-up: delete, comment or scope C macros reported unused #16279
More cases will be removed when dropping WinCE support via #17927.
Cases remain when defining external macros out of curl's control.
Ref: #18477