write-out: make %header{} able to output *all* occurances of a header#18491
Closed
bagder wants to merge 3 commits into
Closed
write-out: make %header{} able to output *all* occurances of a header#18491bagder wants to merge 3 commits into
bagder wants to merge 3 commits into
Conversation
|
Great! Thanks for the quick implementation! I don't know the curl internals enough, the only thing I'd mention here is, if there is a possibility of a recursion, should there any handling for that? (or is this not possible due to the redirect implementation?) |
Member
Author
That's not a risk here. There are several different ways those are prevented (before this code runs): there's a maximum redirections to follow value ( |
This comment was marked as outdated.
This comment was marked as outdated.
f61a564 to
dfcfad2
Compare
dfcfad2 to
15c2c93
Compare
15c2c93 to
6f2b4a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By appending
:all:[separator]to the header name. The[separator]string is output between each header value if there are more than one to output.Test 764 verifies
Idea-by: kapsiR on github
Ref: #18449