tool_cb_hdr: fix fwrite check in header callback#18593
Closed
MegaManSec wants to merge 1 commit intocurl:masterfrom
MegaManSec:tool_cb_hdr
Closed
tool_cb_hdr: fix fwrite check in header callback#18593MegaManSec wants to merge 1 commit intocurl:masterfrom MegaManSec:tool_cb_hdr
MegaManSec wants to merge 1 commit intocurl:masterfrom
MegaManSec:tool_cb_hdr
Conversation
Compare fwrite result to nmemb (items), not cb (bytes).
|
Analysis of PR #18593 at 5c03274f: Test 2405 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 12 different CI jobs (the link just goes to one of them). Generated by Testclutch |
bagder
approved these changes
Sep 18, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare fwrite result to nmemb (items), not cb (bytes).
In every case at the moment,
size == 1, so this doesn't have any real functional change.