libssh2: drop two redundant null-terminations#18606
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
libssh2: drop two redundant null-terminations#18606vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
One of these was added in the initial SFTP commit in 2006: a634f64 At that time this was a reasonable concern because libssh2 started null-terminating this string just one year prior: libssh2/libssh2@efc3841 This fix was released in libssh2 v0.13. curl requires libssh v1.2.8, making this workaround no longer necessary. Follow-up to 9f18cb6 curl#18598
bagder
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The null-termination was first added in the initial SFTP commit in 2006:
a634f64
At that time this was a reasonable concern because libssh2 started
null-terminating this string just one year prior, in 2005:
libssh2/libssh2@efc3841
This fix was released in libssh2 v0.13 (2006-03-02).
curl requires libssh2 v1.2.8, making this workaround no longer necessary.
Follow-up to 9f18cb6 #18598