Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
openssl: Integrate Peter Wu's SSLKEYLOGFILE implementation #1866
This is an adaptation of 2 of Peter Wu's SSLKEYLOGFILE implementations.
The first one, written for old OpenSSL versions:
The second one, written for BoringSSL and new OpenSSL versions:
Note the first one is GPL licensed but the author gave permission to
As of right now this feature is disabled by default, and does not have
And in Wireshark change your preferences to point to that key file:
Co-authored-by: Peter Wu
A build time option that enables USE_CURL_SSLKEYLOGFILE will be added tonight or tomorrow, however I'd like to get this in now before the feature window closes, as discussed over the weekend in #1346.
Looks good to me.
Note that currently you need
CFLAGS=-DUSE_CURL_SSLKEYLOGFILE (or the CMake equivalent) when building as there is no configurable option, is that intentional? (That also sounds reasonable to me.)