New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style overhaul #1878

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@bagder
Copy link
Member

bagder commented Sep 9, 2017

I made checksrc warn for lines of code that use = or + without sufficient spacing next to them. I then changed all code to adhere to this.

Or code style guidelines already says we should write code that way, and most of the code does.

This is the next step in making our code style more uniform.

bagder added some commits Sep 9, 2017

checksrc: verify spaces around equals signs
... as the code style mandates.

@bagder bagder force-pushed the bagder/checksrc-equals-checks branch from 35d0568 to e393459 Sep 11, 2017

@kdudka

This comment has been minimized.

Copy link
Collaborator

kdudka commented Sep 11, 2017

Not very friendly to people who backport patches to curl-7.29.0 and the like, but if it has to be done...

@bagder bagder closed this in 87501e5 Sep 12, 2017

@bagder bagder deleted the bagder/checksrc-equals-checks branch Sep 14, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.