lib: fix build error and compiler warnings with verbose strings disabled#18799
Closed
vszakats wants to merge 3 commits intocurl:masterfrom
Closed
lib: fix build error and compiler warnings with verbose strings disabled#18799vszakats wants to merge 3 commits intocurl:masterfrom
vszakats wants to merge 3 commits intocurl:masterfrom
Conversation
FreeBSD cmake, and clang-tidy:
```
/home/runner/work/curl/curl/lib/multi.c:1107:28: error: code will never be executed [-Werror,-Wunreachable-code]
1107 | size_t timeout_count = Curl_llist_count(&data->state.timeoutlist);
| ^~~~~~~~~~~~~~~~
/home/runner/work/curl/curl/lib/multi.c:3054:35: error: code will never be executed [-Werror,-Wunreachable-code]
3054 | struct Curl_llist_node *e = Curl_llist_head(&data->state.timeoutlist);
| ^~~~~~~~~~~~~~~
/home/runner/work/curl/curl/lib/multi.c:3380:7: error: code will never be executed [-Werror,-Wunreachable-code]
3380 | Curl_llist_head(&data->state.timeoutlist);
| ^~~~~~~~~~~~~~~
3 errors generated.
```
Ref: https://github.com/curl/curl/actions/runs/18177771802/job/51747389974?pr=18797#step:3:2010
Ref: https://github.com/curl/curl/actions/runs/18177900713/job/51747803940?pr=18797#step:8:464
/Users/runner/work/curl/curl/lib/asyn-ares.c:751:17: error: code will never be executed [clang-diagnostic-unreachable-code,-warnings-as-errors]
751 | char *csv = ares_get_servers_csv(ares->channel);
| ^~~~~~~~~~~~~~~~~~~~
1 warning generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyn-ares: fix compiler warning:
curl_trc: fix missing symbol:
Ref: https://app.circleci.com/pipelines/github/curl/curl/15446/workflows/67afa113-9c49-4249-9180-f6f01fc7dfdd/jobs/149177
Ref: https://github.com/curl/curl/actions/runs/18174250400/job/51736249444#step:33:623
Follow-up to b022389 ip-happy: do not set unnecessary timeout #18768
multi: fix
-Wunreachable-code:Cherry-picked from #18797