multi_ev: remove unnecessary data check that confuses analysers#18804
multi_ev: remove unnecessary data check that confuses analysers#18804icing wants to merge 1 commit into
Conversation
| } | ||
| } | ||
| else if(data) | ||
| else |
There was a problem hiding this comment.
Is it worth adding as an assert in the beginning of the function?
There was a problem hiding this comment.
I believe then the analyzers freak out again.
|
clang-tidy and scan-build are happy with this: /off tsan is reporting an issue in non-verbose builds: https://github.com/curl/curl/actions/runs/18187559063/job/51775052767?pr=18797 |
|
Analysis of PR #18804 at d3246073: Test ../../tests/http/test_16_info.py::TestInfo::test_16_01_info_download[h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
4 participants
No description provided.