http2: check push header correctly - #18930
Closed
icing wants to merge 1 commit into
Closed
Conversation
header names delivered by nghttp2 are not 0-terminated. Fix code to accomodate for that. reported-by: Joshua Rogers
Member
|
I think they are nul terminated as per the API docs. |
Member
From: https://nghttp2.org/documentation/types.html#c.nghttp2_on_header_callback |
Member
|
hm, different callback? |
Contributor
Author
|
Anyway, I think checking the length first is better. |
bagder
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
header names delivered by nghttp2 are not 0-terminated. Fix code to accomodate for that.
reported-by: Joshua Rogers