rustls: exit on error#19125
Closed
bagder wants to merge 1 commit into
Closed
Conversation
In init_config_builder_verifier() the call to rustls_root_cert_store_builder_build() set result on failure but did not return. Pointed out by ZeroPath
Member
Author
|
/cc @cpu |
cpu
reviewed
Oct 19, 2025
cpu
left a comment
cpu
left a comment
Contributor
There was a problem hiding this comment.
Thanks! This fix looks good to me. Another point for the AI bot ☑️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In init_config_builder_verifier() the call to
rustls_root_cert_store_builder_build() set result on failure but did not return.
Pointed out by ZeroPath