cmake: honor CURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET in lib and src#19144
Closed
vszakats wants to merge 4 commits into
Closed
cmake: honor CURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET in lib and src#19144vszakats wants to merge 4 commits into
CURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET in lib and src#19144vszakats wants to merge 4 commits into
Conversation
vszakats
force-pushed
the
cm-noinst-fix
branch
from
c1bcb5a to
d0e4cee
Compare
vszakats
changed the title
CURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET to apply to lib and src
vszakats
changed the title
CURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET to apply to lib and srcCURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET to lib and src
vszakats
changed the title
CURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET to lib and srcCURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET where missing
vszakats
changed the title
CURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET where missingCURL_DISABLE_INSTALL and CURL_ENABLE_EXPORT_TARGET in lib and src
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on existing code and commit history it appears
CURL_DISABLE_INSTALLmeans to prevent callinginstall();CURL_ENABLE_EXPORT_TARGETmeans to prevent callingexport()andinstall()s withEXPORTin them.Fix them to also apply to the lib and src directories in that vain:
CURL_DISABLE_INSTALLCURL_DISABLE_INSTALLCURL_ENABLE_EXPORT_TARGEThttps://cmake.org/cmake/help/v4.2/command/install.html
https://cmake.org/cmake/help/v4.2/command/export.html
CURL_DISABLE_INSTALLfollow-up to:aace27b cmake: option to disable install & drop
curlutarget when unused #12287CURL_ENABLE_EXPORT_TARGETfollow-up to:8698825 Improve usability of CMake build as a sub-project #9638
643ec29 CMake: add CURL_ENABLE_EXPORT_TARGET option. #7060
https://github.com/curl/curl/pull/19144/files?w=1