cmake: add and use local FindGnuTLS module #19163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
vszakats
force-pushed
the
cm-find-gnutls
branch
from
ee227e7 to
2912b95
Compare
9 tasks
vszakats
added a commit
that referenced
this pull request
Nov 4, 2025
…module When GnuTLS is detected via pkg-config on a non-default path, e.g. with Homebrew arm64 (`/opt/homebrew/`). This was a regression from a commit made in this release cycle. The Find module doesn't return an absolute path to the detected library (as the former solution did), but a bare libname and a libpath. We thus need to explicitly use the libpath while detecting a feature in GnuTLS found this way. Syncing this with other dependencies. Follow-up to 1966c86 #19163 Closes #19360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing a combination of custom logic in the main script and relying
on CMake's built-in Find module, with code and behavior used for
the rest of dependencies.
Also to:
GNUTLS_INCLUDE_DIRandGNUTLS_LIBRARYtake precedence overpkg-config. As with other dependencies.
IMPORTEDinterface targets #16973, which originally introduced this local Findmodule.
The local module is doing largely the same as CMake's built-in
FindGnuTLS. Differences:
CURL_USE_PKGCONFIG.GNUTLS_VERSION.(CMake's built-in uses s different name in <3.16.)
therefore we may only use it conditionally, which isn't worth it.
Cherry-picked from #16973