Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: read the "no_proxy" variable only if necessary #1919

Closed
wants to merge 1 commit into from

Conversation

mkauf
Copy link
Contributor

@mkauf mkauf commented Sep 24, 2017

No description provided.

Copy link
Member

@bagder bagder left a comment

Just below this section, there's a Curl_safefree(no_proxy) - won't that be wrong when no_proxy points to the data->set.str[] pointer?

@mkauf
Copy link
Contributor Author

mkauf commented Sep 25, 2017

won't that be wrong when no_proxy points to the data->set.str[] pointer?

@bagder Absolutely... thanks a lot for reviewing! I will improve this PR.

@mkauf
Copy link
Contributor Author

mkauf commented Sep 26, 2017

Fixed. I also removed an unnecessary "proxy = NULL" if proxy is already NULL

bagder
bagder approved these changes Oct 3, 2017
@mkauf mkauf closed this in c4ebd8b Oct 3, 2017
@mkauf mkauf deleted the noproxy_env_var branch Oct 3, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants