proxy: read the "no_proxy" variable only if necessary #1919

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@mkauf
Contributor

mkauf commented Sep 24, 2017

No description provided.

@bagder

Just below this section, there's a Curl_safefree(no_proxy) - won't that be wrong when no_proxy points to the data->set.str[] pointer?

@mkauf

This comment has been minimized.

Show comment
Hide comment
@mkauf

mkauf Sep 25, 2017

Contributor

won't that be wrong when no_proxy points to the data->set.str[] pointer?

@bagder Absolutely... thanks a lot for reviewing! I will improve this PR.

Contributor

mkauf commented Sep 25, 2017

won't that be wrong when no_proxy points to the data->set.str[] pointer?

@bagder Absolutely... thanks a lot for reviewing! I will improve this PR.

@mkauf

This comment has been minimized.

Show comment
Hide comment
@mkauf

mkauf Sep 26, 2017

Contributor

Fixed. I also removed an unnecessary "proxy = NULL" if proxy is already NULL

Contributor

mkauf commented Sep 26, 2017

Fixed. I also removed an unnecessary "proxy = NULL" if proxy is already NULL

@bagder

bagder approved these changes Oct 3, 2017

@mkauf mkauf closed this in c4ebd8b Oct 3, 2017

@mkauf mkauf deleted the mkauf:noproxy_env_var branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment