proxy: read the "no_proxy" variable only if necessary#1919
Closed
mkauf wants to merge 1 commit into
Closed
Conversation
bagder
reviewed
Sep 24, 2017
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Just below this section, there's a Curl_safefree(no_proxy) - won't that be wrong when no_proxy points to the data->set.str[] pointer?
Contributor
Author
@bagder Absolutely... thanks a lot for reviewing! I will improve this PR. |
mkauf
force-pushed
the
noproxy_env_var
branch
from
8168d62 to
ac99f01
Compare
Contributor
Author
|
Fixed. I also removed an unnecessary "proxy = NULL" if proxy is already NULL |
bagder
approved these changes
Oct 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.