Skip to content

curl_ngtcp2: fix -Wunreachable-code with H3 !verbose !unity clang - #19226

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:nonverbunity
Closed

vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:nonverbunity

Conversation

@vszakats

@vszakats vszakats commented Oct 24, 2025 •

Copy link
Copy Markdown
Member

Not tested in default CI.

macOS / CM clang OpenSSL gsasl rtmp AppleIDN SecTrust +examples,
macOS / CM llvm@18 OpenSSL gsasl rtmp AppleIDN SecTrust +examples:

lib/vquic/curl_ngtcp2.c:530:5: error: code will never be executed [-Werror,-Wunreachable-code]
  530 |     const ngtcp2_transport_params *rp;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Ref: https://github.com/curl/curl/actions/runs/18787154442/job/53608230871?pr=19225#step:11:183

Confirmed fixed via #19225

…lds'

Not tested in default CI.

macOS / CM clang OpenSSL gsasl rtmp AppleIDN SecTrust +examples:
macOS / CM llvm@18 OpenSSL gsasl rtmp AppleIDN SecTrust +examples:
```
lib/vquic/curl_ngtcp2.c:530:5: error: code will never be executed [-Werror,-Wunreachable-code]
  530 |     const ngtcp2_transport_params *rp;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
Ref: https://github.com/curl/curl/actions/runs/18787154442/job/53608230871?pr=19225#step:11:183
@vszakats vszakats added build HTTP/3 h3 or quic related labels Oct 24, 2025
@vszakats vszakats closed this in 543b786 Oct 24, 2025
@vszakats
vszakats deleted the nonverbunity branch October 24, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

1 participant