cmake: fix HAVE_GNUTLS_SRP detection after adding local FindGnuTLS module#19360
Closed
vszakats wants to merge 1 commit into
Closed
cmake: fix HAVE_GNUTLS_SRP detection after adding local FindGnuTLS module#19360vszakats wants to merge 1 commit into
HAVE_GNUTLS_SRP detection after adding local FindGnuTLS module#19360vszakats wants to merge 1 commit into
Conversation
E.g. on Homebrew arm64 default path (/opt/homebrew/).
vszakats
changed the title
HAVE_GNUTLS_SRP detection for GnuTLS not on system pathHAVE_GNUTLS_SRP after adding local FindGnuTLS module
vszakats
changed the title
HAVE_GNUTLS_SRP after adding local FindGnuTLS moduleHAVE_GNUTLS_SRP detection after adding local FindGnuTLS module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GnuTLS is detected via pkg-config on a non-default path, e.g. with
Homebrew arm64 (
/opt/homebrew/).This was a regression from a commit made in this release cycle.
The Find module doesn't return an absolute path to the detected library
(as the former solution did), but a bare libname and a libpath. We thus
need to explicitly use the libpath while detecting a feature in GnuTLS
found this way. Syncing this with other dependencies.
Follow-up to 1966c86 #19163