tool_help: add checks to avoid unsigned wrap around#19377
Closed
x2018 wants to merge 3 commits into
Closed
Conversation
bagder
approved these changes
Nov 6, 2025
Contributor
Author
Thanks! It would not crash or something dangerous but it will really affect the display width according to https://github.com/curl/curl/blob/master/lib/mprintf.c#L1015. For example as below: When |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_terminal_columns()can returncolsfrom 1-10000 (21-10000 only via envCOLUMNS), while thelongdescin option--help allis47.When
cols < 47, the unsigned subtractioncols - longdescwraps around to a large value, which is then passed as negative width tocurl_mprintfafter conversion to int.Therefore, it is better to properly check the unsigned boundary to avoid unsigned wrap around and any other unexpected/undefined behavior.