lib: refactor the type of funcs which have useless return and checks #19386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
meanless_ret_cleanup
branch
from
7f5ca7f to
9ad1b95
Compare
bagder
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some internal functions always return
CURLE_OK.Curl_http_proxy_get_destination()does that from bb4032a, (2 years ago) And the original inline code does not need to check the status.Curl_wildcard_init()does that from e60fe20. (8 years ago)Curl_initinfo()does that from a very beginning.Curl_pgrsSetDownloadCounter()did not have a return before 914e49b, ad051e1 recovered its content (2 years ago) but did not completely recovered the changes related to it.auth_digest_get_qop_values()does that from 676de7f.This PR directly changes their type to
voidand cleaned the remaining checks for their return value.