Conversation
bagder
added
TLS
feature-window
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Pull request overview
This PR adds initial support for MQTTS (MQTT over TLS), extending curl's MQTT protocol support with TLS/SSL encryption. The implementation follows the established pattern of other secure protocol variants (like HTTPS, FTPS, IMAPS) by creating a separate protocol handler that uses stunnel for TLS termination in tests.
Key changes:
- Adds MQTTS protocol handler with TLS support in the core library
- Implements test infrastructure for MQTTS including a new test case (test1640)
- Updates documentation across multiple files to include MQTTS in protocol lists
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/mqtt.c | Adds mqtts_connecting function and Curl_handler_mqtts protocol handler for MQTTS support |
| lib/mqtt.h | Declares external Curl_handler_mqtts handler |
| lib/url.c | Registers MQTTS handler in the scheme handler table |
| lib/urldata.h | Defines PORT_MQTTS constant (8883) |
| lib/version.c | Adds "mqtts" to supported protocols list |
| include/curl/curl.h | Defines CURLPROTO_MQTTS protocol constant |
| scripts/schemetable.c | Adds mqtts entry to scheme table for code generation |
| tests/servers.pm | Adds MQTTS server startup logic and protocol handling |
| tests/serverhelp.pm | Updates protocol regex to recognize MQTTS |
| tests/data/test1640 | New test case for MQTTS SUBSCRIBE operation |
| tests/data/Makefile.am | Adds test1640 to test suite |
| docs/tests/FILEFORMAT.md | Documents %MQTTSPORT variable for test files |
| docs/libcurl/symbols-in-versions | Adds CURLPROTO_MQTTS version entry (8.19.0) |
| docs/libcurl/opts/CURLOPT_REDIR_PROTOCOLS_STR.md | Adds MQTTS to protocol list |
| docs/libcurl/opts/CURLOPT_REDIR_PROTOCOLS.md | Adds CURLPROTO_MQTT constant (missing CURLPROTO_MQTTS) |
| docs/libcurl/opts/CURLOPT_PROTOCOLS_STR.md | Adds MQTTS to protocol list |
| docs/internals/MQTT.md | Documents mqtts:// URL scheme usage |
| docs/cmdline-opts/_DESCRIPTION.md | Adds MQTTS to curl supported protocols |
| docs/FAQ.md | Updates supported protocols list (contains typo) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vszakats
reviewed
Dec 18, 2025
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Dec 19, 2025
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jan 17, 2026
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jan 17, 2026
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.