schannel: fix potential memory leak of cert_store_path#19423
Closed
x2018 wants to merge 2 commits into
Closed
Conversation
`cert_store_path` is not be used in (fInCert || blob) branch. This commit moves the previously added free(cert_store_path) to the front of the branch, so that we do not need to do it on the subsequent three error paths under the branch.
x2018
changed the title
bagder
approved these changes
Nov 10, 2025
bagder
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cert_store_pathis allocated viaget_cert_location()aftercert_pathis allocated.This PR fixes the potential memory leak of cert_store_path on four (original) error paths.
Overall, three of the four error paths are under the branch if(fInCert || blob) {...) and it is not actually used in the branch, so I just free it at the beginning of the branch along with
curlx_unicodefree(cert_path);.