Skip to content

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Nov 9, 2025

Before this patch servers were loading the original data source file
(from tests/data/test*) if they failed to open the preprocessed data
file.

It was causing issues in many (most?) tests, because original data files
are not preprocessed, thus may be incomplete and/or come with wrong
newline characters. It's also causing difficult to diagnose issues when
a test accidentally references another test's data, which by chance
makes the test pass initially, until either that or the executed test
data gets an update, and breaking it, as seen in #19329.

Historically, the fallback existed first, then the preprocessed copy.
The fallback is no longer used by tests (except by stray accidents).

Fix it by dropping the fallback logic and relying on the preprocessed
data file saved there by the runtests framework.

Also fix two remaining test data cross-references:

Follow-up to aaf9522 #19329


  • fix test 3014.
  • fix test 1565.

@vszakats vszakats added the tests label Nov 9, 2025
@vszakats vszakats marked this pull request as draft November 9, 2025 18:47
@testclutch

This comment was marked as resolved.

@vszakats vszakats marked this pull request as ready for review November 9, 2025 19:28
@vszakats vszakats changed the title tests/server: do not fall back to original data files in test2fopen() tests/server: do not fall back to original data file in test2fopen() Nov 9, 2025
@vszakats vszakats closed this in c6f1b0f Nov 9, 2025
@vszakats vszakats deleted the tt5 branch November 9, 2025 20:15
vszakats added a commit to vszakats/curl that referenced this pull request Nov 12, 2025
vszakats added a commit to vszakats/curl that referenced this pull request Nov 13, 2025
vszakats added a commit that referenced this pull request Nov 13, 2025
Special meanings of URLs became outdated, and it's also no longer
necessary to pass the test number via the URL or domain anymore.
Delete the text.

Follow-up to c6f1b0f #19429

Closes #19503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants