New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/config-win32.h: let SMB/SMBS be enabled with OpenSSL/NSS #1943

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@vszakats
Member

vszakats commented Oct 4, 2017

The source code is now prepared to handle the case when both
Win32 Crypto and OpenSSL/NSS crypto backends are enabled
at the same time, making it possible to enable USE_WIN32_CRYPTO
whenever the targeted Windows version supports it. Since this
matches the minimum Windows version supported by curl
(Windows 2000), enable it unconditionally for the Win32 platform.

This in turn enables SMB (and SMBS) protocol support whenever
Win32 Crypto is available, regardless of what other crypto backends
are enabled.

Ref: #1840 (comment)

Show outdated Hide outdated lib/config-win32.h
lib/config-win32.h: let win32 crypto be enabled with openssl/nss
The source code is now prepared to handle the case when both
Win32 Crypto and OpenSSL/NSS crypto backends are enabled
at the same time, making it now possible to enable `USE_WIN32_CRYPTO`
whenever the targeted Windows version supports it. Since this
matches the minimum Windows version supported by curl
(Windows 2000), enable it unconditionally for the Win32 platform.

This in turn enables SMB (and SMBS) protocol support whenever
Win32 Crypto is available, regardless of what other crypto backends
are enabled.

Ref: #1840 (comment)

@vszakats vszakats changed the title from lib/config-win32.h: let win32 crypto be enabled with openssl/nss to lib/config-win32.h: let smb/smbs be enabled with openssl/nss Oct 6, 2017

@vszakats vszakats changed the title from lib/config-win32.h: let smb/smbs be enabled with openssl/nss to lib/config-win32.h: let SMB/SMBS be enabled with OpenSSL/NSS Oct 6, 2017

@vszakats vszakats closed this in 24bba40 Oct 6, 2017

@vszakats vszakats deleted the vszakats:smbauto branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment