scripts: use end-of-options marker in find -exec commands - #19450
Closed
vszakats wants to merge 1 commit into
Closed
scripts: use end-of-options marker in find -exec commands#19450vszakats wants to merge 1 commit into
find -exec commands#19450vszakats wants to merge 1 commit into
Conversation
This was referenced Jun 24, 2026
vszakats
added a commit
that referenced
this pull request
Jun 25, 2026
…` commands Where missing. To avoid passing an option by accident. End-of-option marker (`--`) is not POSIX, but most of these scripts are internal and/or CI-focused, where this is fine. `maketgz` and `verify-release` are meant for public use, and I asses this is fine too, but let us know if this causes issues in real world envs. Also: - maketgz: pass args with `:?` to `rm -rf`, where missing. Cannot cause an actual issue with current code. - verified `cp`, `rm` instances too, but none were affected. - tests/cmake/test.sh: replace `$PWD` with `$(pwd)` for sturdiness. - appveyor.sh: replace `$PWD` with `$(pwd)` for sturdiness. Assisted-by: Dan Fandrich Follow-up to 6aab1dc #19450 Closes #22150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.