sftp: fix range downloads in both SSH backends#19460
Closed
bagder wants to merge 9 commits into
Closed
Conversation
When asking for the last N bytes of a file, and that size was larger than the file size, it would miss the first byte due to a logic error. The fixed range parser is now made a common function in the file now renamed to vssh.c (from curl_path.c) - used by both backends. Reported-by: Stanislav Fort (Aisle Research)
This comment was marked as resolved.
This comment was marked as resolved.
bagder
marked this pull request as ready for review
November 11, 2025 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When asking for the last N bytes of a file, and that size was larger than the file size, it would miss the first byte due to a logic error.
The fixed range parser is now made a common function in the file now renamed to vssh.c (from curl_path.c) - used by both backends.
Reported-by: Stanislav Fort (Aisle Research)