openssl: exit properly on OOM when getting certchain#19471
Closed
bagder wants to merge 1 commit into
Closed
Conversation
Member
|
Could I merge #18330 before this patch? |
Member
Author
|
A reasonable request. Sure! I will just make sure that this doesn't break any tests and keep it open here until after that PR merges. |
Previously, a momentary OOM error in the middle could produce a broken result instead of correctly returning error.
bagder
force-pushed
the
bagder/openssl-certchain
branch
from
d686de5 to
fbfd97d
Compare
vszakats
added a commit
that referenced
this pull request
Dec 31, 2025
(Not tested in CI. Regression within this release cycle.)
Fixing:
```
lib/vtls/openssl.c:304:48: error: unused parameter 'data' [-Werror,-Wunused-parameter]
304 | static CURLcode get_pkey_dsa(struct Curl_easy *data,
| ^
lib/vtls/openssl.c:305:40: error: unused parameter 'pubkey' [-Werror,-Wunused-parameter]
305 | EVP_PKEY *pubkey, BIO *mem, int i)
| ^
lib/vtls/openssl.c:305:53: error: unused parameter 'mem' [-Werror,-Wunused-parameter]
305 | EVP_PKEY *pubkey, BIO *mem, int i)
| ^
lib/vtls/openssl.c:305:62: error: unused parameter 'i' [-Werror,-Wunused-parameter]
305 | EVP_PKEY *pubkey, BIO *mem, int i)
| ^
```
Follow-up to 833efb4 #19471
Closes #20127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a momentary OOM error in the middle could produce a broken result instead of correctly returning error.