openssl: enable PKCS12 support for !BoringSSL #1948

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

bagder commented Oct 5, 2017

Enable PKCS12 for all non-boringssl builds without relying on configure
or cmake checks.

Bug: https://curl.haxx.se/mail/lib-2017-10/0007.html
Reported-by: Christian Schmitz

openssl: enable PKCS12 support for !BoringSSL
Enable PKCS12 for all non-boringssl builds without relying on configure
or cmake checks.

Bug: https://curl.haxx.se/mail/lib-2017-10/0007.html
Reported-by: Christian Schmitz

@bagder bagder closed this in 62a721e Oct 9, 2017

@bagder bagder deleted the bagder/openssl-pkcs12 branch Oct 9, 2017

Owner

bagder commented Oct 9, 2017

No feedback on this take but I merged anyway as I believe this is the right way forward.

Member

gvanem commented Nov 22, 2017

What about the case with multiple SSL backends; both -DUSE_OPENSSL (meaning true OpenSSL) and
-DOPENSSL_IS_BORINGSSL?

Is it possible to detect that at compile time? No #error don't do that! for that in the code now AFAICS..

Owner

jay commented Nov 22, 2017

What about the case with multiple SSL backends; both -DUSE_OPENSSL (meaning true OpenSSL) and
-DOPENSSL_IS_BORINGSSL?

I don't think it's possible to use both of those at the same time. edit: I mean you either use openssl or boringssl. USE_OPENSSL should be defined in either case

Member

gvanem commented Nov 22, 2017

I know; I got the error for a missing <pkcs12.h> in BoringSSL. Hence the question.

Owner

jay commented Nov 22, 2017

I'm lost. If you are building with BoringSSL then the pkcs stuff should not be included. In other words -DUSE_OPENSSL -DOPENSSL_IS_BORINGSSL then no pkcs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment