test2045: replace HTML multi-line comment markup with # comments
#19498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfandrich
approved these changes
Nov 12, 2025
Contributor
dfandrich
left a comment
dfandrich
left a comment
There was a problem hiding this comment.
I only hacked in enough support to handle single-line XML-style comments, so this helps reduce confusion.
Member
Author
|
With %LT, %GT and %AMP, it's down to 5 non-compliant files at #19470. One awkward place to use %AMP is Perl snippets with |
Contributor
|
One awkward place to use %AMP is Perl snippets with && in them.
A handful of full HTML/XML data content and #include <curl/curl.h>
also become a bit weird. Something to think about if there are more
elegant ways to handle them.
I haven't thought of any, which is why I just lived with it. Switching to
entities/macros really does hamper readability.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As used everywhere else in tests/data. To play nice with XML.
Follow-up to 9756d1d