_PROGRESS.md: add the E unit, mention kibibyte #19502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suffixes used are not standard since we want them to be single characters and the proper ones would be KiB, MiB etc.
Contributor
|
"E" has somewhat of a conflict with exponential notation. Does "12E+3k" mean 12000 kilobytes or 12 exabytes plus 3 kilobytes?
|
Member
Author
|
Sure, but I don't see what other option we have. Also, it will say |
Contributor
|
It turns out humanize_number() and dehumanize_number() (from the BSDs) already support the E suffix in this way, so I withdraw my concern.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suffixes used are not standard since we want them to be single characters and the proper ones would be KiB, MiB etc.