pytest fixes and improvements#19540
Closed
icing wants to merge 1 commit into
Closed
Conversation
- fix test_17_20 flakiness: the test case did not have `nghttpx` in its parameters, causing it to no check if a reload was necessary. When that test ran behind one that gave nghttpx another certificate, eg. in parallel mode, it used the wrong pinned pubkey. - Have `env` provide lists of HTTP protocol versions available for testing. Replace parameterized tests on a fixed protocol list with the dynamic one from env. This makes checks for protocol availability in the test function bodies superfluous.
vszakats
approved these changes
Nov 15, 2025
Member
There was a problem hiding this comment.
Nice!
Noticed this at the end of the log of a successful H3 job, seemed unfamiliar,
but it's unrelated, and present in master too:
Traceback (most recent call last):
File "/home/runner/work/curl/curl/tests/http/testenv/env.py", line 219, in __init__
self._nghttpx_version = NghttpxUtil.version(self.nghttpx)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/curl/curl/tests/http/testenv/env.py", line 83, in version
raise RuntimeError(f'{cmd} --version failed with exit code: {p.returncode}')
RuntimeError: /home/runner/nghttp2/build/bin/nghttpx --version failed with exit code: 1
https://github.com/curl/curl/actions/runs/19389791408/job/55481684596#step:27:1695
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nghttpxin its parameters, causing it to no check if a reload was necessary. When that test ran behind one that gave nghttpx another certificate, eg. in parallel mode, it used the wrong pinned pubkey.envprovide lists of HTTP protocol versions available for testing. Replace parameterized tests on a fixed protocol list with the dynamic one from env. This makes checks for protocol availability in the test function bodies superfluous.refs #19489