build: exclude clang prereleases from compiler warning options #19566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Nov 17, 2025
Starting with clang 18, stable clang releases start with minor version 1. Exclude prereleases with minor version 0 from the compiler warning options for that major version. This fixes the build with Android NDK r29, which uses a prerelease version of clang 21 that doesn't know the new options yet. Closes curl#19566
MarcelRaad
force-pushed
the
clang_warnings_exclude_prereleases
branch
from
3916049 to
09a0845
Compare
vszakats
approved these changes
Nov 17, 2025
Member
|
Agree, nice catch! |
Member
|
GH issues... |
Member
|
@MarcelRaad try pushing again, to trigger CI one more time? |
Starting with clang 18, stable clang releases start with minor version 1. Exclude prereleases with minor version 0 from the compiler warning options for that major version. This fixes the build with Android NDK r29, which uses a prerelease version of clang 21 that doesn't know the new options yet. Closes curl#19566
MarcelRaad
force-pushed
the
clang_warnings_exclude_prereleases
branch
from
09a0845 to
f2e0969
Compare
Member
Author
|
Looks better now. Thanks! |
Member
|
Thanks @MarcelRaad, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with clang 18, stable clang releases start with minor version 1.
Exclude pre-releases with minor version 0 from the compiler warning
options for that major version.
This fixes the build with Android NDK r29, which uses a prerelease
version of clang 21 that doesn't know the new options yet.