pingpong: return error when trying to send without connection #1960

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
1 participant
@bagder
Member

bagder commented Oct 6, 2017

When imap_done() got called before a connection is setup, it would try
to "finish up" and dereffed a NULL pointer.

Test case 1553 managed to reproduce. I had to actually use a host name
to try to resolve to slow it down, as using the normal local server IP
will make libcurl get a connection in the first curl_multi_perform()
loop and then the bug doesn't trigger.

Fixes #1953
Assisted-by: Max Dymond

pingpong: return error when trying to send without connection
When imap_done() got called before a connection is setup, it would try
to "finish up" and dereffed a NULL pointer.

Test case 1553 managed to reproduce. I had to actually use a host name
to try to resolve to slow it down, as using the normal local server IP
will make libcurl get a connection in the first curl_multi_perform()
loop and then the bug doesn't trigger.

Fixes #1953
Assisted-by: Max Dymond
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Oct 7, 2017

Member

Nasty valgrind errors there I need to fix before this can move.

Member

bagder commented Oct 7, 2017

Nasty valgrind errors there I need to fix before this can move.

bagder added some commits Oct 7, 2017

@bagder bagder closed this in 1e55253 Oct 7, 2017

@bagder bagder deleted the bagder/imap-mime-sigsegv branch Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment