New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not jump over semicolons when filename contains a path #1964

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@cuklev
Contributor

cuklev commented Oct 7, 2017

Content-Disposition: attachment; filename=correct.jpg; somethingelse=/wrong.jpg
curl -O -J saves to wrong.jpg when it should probably save to correct.jpg.

@cuklev cuklev changed the title from Do not jump over seimicolons when filename contains a path to Do not jump over semicolons when filename contains a path Oct 7, 2017

@bagder

bagder approved these changes Oct 9, 2017

Looks good. I also updated test 1422 to verify this and will amend your commit with it when I merge!

@bagder

This comment has been minimized.

Member

bagder commented Oct 9, 2017

Thanks!

@bagder bagder closed this in c95c92d Oct 9, 2017

@cuklev cuklev deleted the cuklev:content-disposition-filename-parse branch Dec 5, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.