curl_fopen: do not pass invalid mode flags to open() on Windows
#19645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
vszakats
changed the title
open() on Windowsopen() on Windows
MarcelRaad
approved these changes
Nov 22, 2025
The safe variants of the Windows `open()` reject these, while the classic ones ignore it. Also: - also drop the now unused `stat()` call on Windows. - replace magic number with their equivalent Windows and Unix-specific `S_*` macros. https://learn.microsoft.com/cpp/c-runtime-library/reference/open-wopen https://learn.microsoft.com/cpp/c-runtime-library/reference/fstat-fstat32-fstat64-fstati64-fstat32i64-fstat64i32
1 task
vszakats
added a commit
that referenced
this pull request
Nov 24, 2025
Ref: https://learn.microsoft.com/cpp/c-runtime-library/reference/open-wopen Ref: #19645 Cherry-picked from #19643 Closes #19647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The safe (
_s) variants of the Windowsopen()reject these flags,while the classic ones silently accepted them.
Also:
stat()call on Windows.S_*macros.Refs:
https://learn.microsoft.com/cpp/c-runtime-library/reference/open-wopen
https://learn.microsoft.com/cpp/c-runtime-library/reference/fstat-fstat32-fstat64-fstati64-fstat32i64-fstat64i32
Cherry-picked from #19643
sys/stat.hwhich is included fromcurl_setup*.h(twice even, for Windows), orfcntl.hif available, which is included fromcurl_setup_once.h, also fromcurlx/fopen.hviacurl_fopen.h.