Skip to content

Conversation

@bagder
Copy link
Member

@bagder bagder commented Nov 22, 2025

If get_args() returns error, do not overwrite the variable in the next call.

Also, avoid allocating memory for the default user-agent.

If get_args() returns error, do not overwrite the variable in the next
call.

Also, avoid allocating memory for the default user-agent.
@testclutch
Copy link

Analysis of PR #19650 at 56b56370:

Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-def] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-AES128ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-AES256ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-CHACHA20ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-AES256ish+CHACHA20ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-AES128SHA384+CHACHA20SHA256-def] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-AES128SHA384+CHACHA20SHA256-AES128ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them).

There are more failures, but that's enough from Gha.

Generated by Testclutch

@bagder
Copy link
Member Author

bagder commented Nov 22, 2025

These macOS CI failures are new but not because of this PR...

@bagder bagder marked this pull request as ready for review November 22, 2025 21:07
@bagder bagder closed this in 36b9987 Nov 22, 2025
@bagder bagder deleted the bagder/tool-param branch November 22, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants