tool_operate: fix a case of ignoring return code#19650
Conversation
If get_args() returns error, do not overwrite the variable in the next call. Also, avoid allocating memory for the default user-agent.
|
Analysis of PR #19650 at 56b56370: Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-def] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-AES128ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-AES256ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-CHACHA20ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-CHACHA20SHA256-AES256ish+CHACHA20ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-AES128SHA384+CHACHA20SHA256-def] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_07_ssl_ciphers[TLSv1.2+3-AES128SHA384+CHACHA20SHA256-AES128ish] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 6 different CI jobs (the link just goes to one of them). There are more failures, but that's enough from Gha. Generated by Testclutch |
|
These macOS CI failures are new but not because of this PR... |
If get_args() returns error, do not overwrite the variable in the next call.
Also, avoid allocating memory for the default user-agent.