speedcheck: do not trigger low speed cancelation on transfers paused with CURL_READFUNC_PAUSE - #19653
Closed
bttrfl wants to merge 1 commit into
Closed
speedcheck: do not trigger low speed cancelation on transfers paused with CURL_READFUNC_PAUSE#19653bttrfl wants to merge 1 commit into
bttrfl wants to merge 1 commit into
Conversation
…with CURL_READFUNC_PAUSE When a trasfer is paused from a read callback with a CURL_READFUNC_PAUSE code, it should be excluded from the speedcheck. Currently only transfers paused from write callbacks are excluded, because the code only checks for "recv direction" of the transfer. This commit adds a check for "send direction". Issue similar to curl#6358
bttrfl
marked this pull request as ready for review
November 23, 2025 04:37
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
@bttrfl thanks, I think this is good. Could you rebase on master? I think the CI failures should be fixed that way. |
Contributor
|
If you do not have the time, I can take this change in to #19384 where I work on rate limits improvements. |
icing
self-requested a review
November 24, 2025 10:18
Member
|
Thanks! |
Contributor
Author
|
Thanks! |
robot-piglet
pushed a commit
to ytsaurus/ytsaurus
that referenced
this pull request
Nov 24, 2025
Некорректно работает ограничение CURLOPT\_LOW\_SPEED\_LIMIT для приостановленных через CURL\_READFUNC\_PAUSE (или curl\_pause, тут неважно) upload'ов. По документации, для таких запросов проверка не должна срабатывать, а на практике это не так: запрос ставится на паузу и потом отваливается по лимиту. Нас сейчас эта проблема блокирует: пятисотим на медленных s3 клиентах, поэтому пока ждем мержа [PR](curl/curl#19653) в апстрим и релиза, занес патч сюда В тикете чуть больше подробностей commit_hash:3fe9cfbc23430dd59643f0915943455caad3db97
robot-piglet
pushed a commit
to ydb-platform/ydb
that referenced
this pull request
Nov 24, 2025
Некорректно работает ограничение CURLOPT\_LOW\_SPEED\_LIMIT для приостановленных через CURL\_READFUNC\_PAUSE (или curl\_pause, тут неважно) upload'ов. По документации, для таких запросов проверка не должна срабатывать, а на практике это не так: запрос ставится на паузу и потом отваливается по лимиту. Нас сейчас эта проблема блокирует: пятисотим на медленных s3 клиентах, поэтому пока ждем мержа [PR](curl/curl#19653) в апстрим и релиза, занес патч сюда В тикете чуть больше подробностей commit_hash:3fe9cfbc23430dd59643f0915943455caad3db97
robot-piglet
pushed a commit
to ytsaurus/ytsaurus
that referenced
this pull request
Nov 24, 2025
Некорректно работает ограничение CURLOPT\_LOW\_SPEED\_LIMIT для приостановленных через CURL\_READFUNC\_PAUSE (или curl\_pause, тут неважно) upload'ов. По документации, для таких запросов проверка не должна срабатывать, а на практике это не так: запрос ставится на паузу и потом отваливается по лимиту. Нас сейчас эта проблема блокирует: пятисотим на медленных s3 клиентах, поэтому пока ждем мержа [PR](curl/curl#19653) в апстрим и релиза, занес патч сюда В тикете чуть больше подробностей commit_hash:3fe9cfbc23430dd59643f0915943455caad3db97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have encountered an issue similar to #6358.
When pausing an upload, it is not actually excluded from the low speed cancelation. The issue seems to be that the condition in the code only checks if the "recv direction" of the transfer is paused, but not the "send direction".
Adding
Curl_xfer_send_is_pausedto the condition fixed the issuelibcurl version: 8.17
tested with protocols: http/https