Skip to content

Conversation

@yedayak
Copy link
Contributor

@yedayak yedayak commented Nov 23, 2025

Inspired by @vszakats in #19631 (comment)

I'm note sure this is the best way to do this? I don't love adding the output variable, so open for other suggestions.

@testclutch
Copy link

Analysis of PR #19663 at e97f92a0:

Test 433 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Test 436 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Generated by Testclutch

@yedayak yedayak marked this pull request as draft November 23, 2025 21:44
@yedayak yedayak marked this pull request as ready for review November 24, 2025 11:23
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I could not think of any immediate way to do it better.

@bagder bagder closed this in fc09a2d Nov 25, 2025
@bagder
Copy link
Member

bagder commented Nov 25, 2025

thanks!

@vszakats
Copy link
Member

Thanks @yedayak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants