multi: fix memory leak when stopped during name resolve #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
changed the title
bagder
force-pushed
the
bagder/multi-done-memory-leak-fix
branch
from
c005bf8 to
c14cf05
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
jay
force-pushed
the
bagder/multi-done-memory-leak-fix
branch
from
c14cf05 to
f80f374
Compare
bagder
force-pushed
the
bagder/multi-done-memory-leak-fix
branch
from
f80f374 to
c4b6e2a
Compare
When the application just started the transfer and then stops it while the name resolve in the background thread hasn't completed, we need to wait for the resolve to complete and then cleanup data accordingly. Enabled test 1553 again, added test 1590 to also check when the host name resolves successfully. Detected by OSS-fuzz.
bagder
force-pushed
the
bagder/multi-done-memory-leak-fix
branch
from
c4b6e2a to
9ec94b5
Compare
|
I rebased the earlier work and restarted my work on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application just started the transfer and then stops it while
the name resolve in the background thread hasn't completed, we need to
wait for the resolve to complete and then cleanup data accordingly.
Enabled test 1553 again, added test 1554 to also check when the host
name resolves successfully.
Detected by OSS-fuzz.