New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: fix memory leak when stopped during name resolve #1968

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@bagder
Copy link
Member

bagder commented Oct 8, 2017

When the application just started the transfer and then stops it while
the name resolve in the background thread hasn't completed, we need to
wait for the resolve to complete and then cleanup data accordingly.

Enabled test 1553 again, added test 1554 to also check when the host
name resolves successfully.

Detected by OSS-fuzz.

@bagder bagder added the memory-leak label Oct 8, 2017

@bagder bagder changed the title multi: fix memory leak when stoped during name resolve multi: fix memory leak when stopped during name resolve Oct 8, 2017

@bagder bagder force-pushed the bagder/multi-done-memory-leak-fix branch from c005bf8 to c14cf05 Oct 8, 2017

@stale

This comment has been minimized.

Copy link

stale bot commented Apr 6, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2018

@jay jay force-pushed the bagder/multi-done-memory-leak-fix branch from c14cf05 to f80f374 Apr 7, 2018

@stale stale bot removed the stale label Apr 7, 2018

@bagder bagder force-pushed the bagder/multi-done-memory-leak-fix branch from f80f374 to c4b6e2a Jun 14, 2018

multi: fix memory leak when stopped during name resolve
When the application just started the transfer and then stops it while
the name resolve in the background thread hasn't completed, we need to
wait for the resolve to complete and then cleanup data accordingly.

Enabled test 1553 again, added test 1590 to also check when the host
name resolves successfully.

Detected by OSS-fuzz.

@bagder bagder force-pushed the bagder/multi-done-memory-leak-fix branch from c4b6e2a to 9ec94b5 Jun 15, 2018

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jun 15, 2018

I rebased the earlier work and restarted my work on this.

@bagder bagder closed this in ac9a179 Jun 16, 2018

@bagder bagder deleted the bagder/multi-done-memory-leak-fix branch Jun 16, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Sep 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.