ssh: tracing and better pollset handling - #19745
Closed
icing wants to merge 3 commits into
Closed
Conversation
Remove connection member `waitfor` and keep it in the SSH connection meta. Add `ssh` to supported tracing features, convert many DEBUGF printgs to traces.
Contributor
Author
|
@vszakats will be interesting to see if this makes Windows builds using libssh more reliable. |
bagder
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove connection member
waitforand keep it in the SSH connection meta. Addsshto supported tracing features, convert many DEBUGF prints to traces.Fix broken
libssh.cstate machine loop to continue processing while libssh reports somerc != 0codes as errors are handled by progressing into error states which need then handling, not waiting on some poll event that may never come.