rtmp: stop redefining setsockopt system symbol on Windows - #19768
Closed
vszakats wants to merge 4 commits into
Closed
rtmp: stop redefining setsockopt system symbol on Windows#19768vszakats wants to merge 4 commits into
setsockopt system symbol on Windows#19768vszakats wants to merge 4 commits into
Conversation
Follow-up to 04cb15a
vszakats
changed the title
setsockopt system symbol on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch it added Windows-specific casts. In unity builds this
also affected other source files.
setsockopt()is called without special casts in other places inthe code, and passing a non-const char ptr to a const char ptr arg also
should work.
Basic compile test with mingw-w64 confirms. In case of issues, a cast to
curl_socklen_tcan be used, or do the special case in an#ifbranch.Also: merge Windows-specific guards for
SET_RCVTIMEO().Follow-up to 639d052 #3155
Follow-up to 04cb15a